Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands attributes-display-all and attributes-display-none #2790

Open
aadcg opened this issue Feb 14, 2023 · 6 comments
Open

Add commands attributes-display-all and attributes-display-none #2790

aadcg opened this issue Feb 14, 2023 · 6 comments
Labels
low prompt-buffer Related to the prompt buffer.

Comments

@aadcg
Copy link
Member

aadcg commented Feb 14, 2023

These commands would complement toggle-attributes-display since they would show/hide all attributes in one go without having to mark/unmark them in the prompt buffer.

Additionally, a user option could globally prevent from rendering attributes.

@aadcg aadcg added low prompt-buffer Related to the prompt buffer. labels Feb 14, 2023
@Ambrevar
Copy link
Member

I like it!

@aadcg
Copy link
Member Author

aadcg commented Oct 23, 2023

@hgluka This is related to what you have been working on. While not being a top priority, it doesn't hurt to get it done while the focus is on a tangent topic.

@hgluka
Copy link
Contributor

hgluka commented Oct 25, 2023

Would we need buttons for these commands in the prompt buffer, along with toggle-attributes-display?

@aadcg
Copy link
Member Author

aadcg commented Oct 25, 2023

No, that's outside of the scope right now. The commands should be bound to keys.

@hgluka
Copy link
Contributor

hgluka commented Oct 25, 2023

Do you have any good suggestions for keybindings?
toggle-attributes-display is currently C-] in CUA (and Emacs) mode and z a in vi mode.
Are there any similar commands/keybindings in Emacs, for example, that we should try to replicate in the case of attributes-display-all and attributes-display-none?

@aadcg
Copy link
Member Author

aadcg commented Oct 25, 2023

It could be C-shift-] and the command would toggle between hiding and showing all attributes. I have never used vi so I can't suggest a keybinding. It's ok to just bind it in the default keyscheme, from which all others inherit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low prompt-buffer Related to the prompt buffer.
Development

No branches or pull requests

3 participants