Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dummy renderer to load HTML, then use it in tests #2932

Open
Ambrevar opened this issue Apr 26, 2023 · 2 comments
Open

Allow dummy renderer to load HTML, then use it in tests #2932

Ambrevar opened this issue Apr 26, 2023 · 2 comments
Assignees
Labels
high test Testing and benchmarking.

Comments

@Ambrevar
Copy link
Member

As pointed out in #2906 (comment), the fundamental reason why we need to load GTK to run tests that rely on testing URL and HTML loading is because we heavily depend on on-signal-decide-policy and friends in our core logic, which is only to be found in the GTK renderer.

Indeed, the dummy renderer makes no call to it.

This is problematic in particular with tests, because GTK tests are more cumbersome to write and slower to run (because of all the setup / teardown). Most importantly, we currently cannot run it in the CI.

We could fix it all in one go if we allowed our dummy renderer to do more. After all, loading an HTML file into memory is trivial.
Then we already have the dexador dependency to load URLs. So really, it should be just some easy refactoring.

@Ambrevar Ambrevar added high test Testing and benchmarking. labels Apr 26, 2023
@aadcg
Copy link
Member

aadcg commented Apr 26, 2023

I like the approach! When should we tackle this one? Post 3.0 release?

@Ambrevar
Copy link
Member Author

It's not critical for 3.0, but would make our life easier for sure! :)

@aadcg aadcg self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high test Testing and benchmarking.
Development

No branches or pull requests

2 participants