You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As pointed out in #2906 (comment), the fundamental reason why we need to load GTK to run tests that rely on testing URL and HTML loading is because we heavily depend on on-signal-decide-policy and friends in our core logic, which is only to be found in the GTK renderer.
Indeed, the dummy renderer makes no call to it.
This is problematic in particular with tests, because GTK tests are more cumbersome to write and slower to run (because of all the setup / teardown). Most importantly, we currently cannot run it in the CI.
We could fix it all in one go if we allowed our dummy renderer to do more. After all, loading an HTML file into memory is trivial.
Then we already have the dexador dependency to load URLs. So really, it should be just some easy refactoring.
The text was updated successfully, but these errors were encountered:
As pointed out in #2906 (comment), the fundamental reason why we need to load GTK to run tests that rely on testing URL and HTML loading is because we heavily depend on
on-signal-decide-policy
and friends in our core logic, which is only to be found in the GTK renderer.Indeed, the dummy renderer makes no call to it.
This is problematic in particular with tests, because GTK tests are more cumbersome to write and slower to run (because of all the setup / teardown). Most importantly, we currently cannot run it in the CI.
We could fix it all in one go if we allowed our dummy renderer to do more. After all, loading an HTML file into memory is trivial.
Then we already have the dexador dependency to load URLs. So really, it should be just some easy refactoring.
The text was updated successfully, but these errors were encountered: