Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace quick start navigation arrows with those of status buffer #3112

Closed
aadcg opened this issue Aug 4, 2023 · 15 comments · Fixed by #3154
Closed

Replace quick start navigation arrows with those of status buffer #3112

aadcg opened this issue Aug 4, 2023 · 15 comments · Fixed by #3154
Assignees
Labels
ui/ux Nyxt User Interface: themes, appearance and usability.

Comments

@aadcg
Copy link
Member

aadcg commented Aug 4, 2023

With the addition of the new arrows, it would be great to be consistent.

2023_08_04_15:21:00-nyxt

@jmercouris? :)

@aadcg aadcg added the ui/ux Nyxt User Interface: themes, appearance and usability. label Aug 4, 2023
@jmercouris
Copy link
Member

it can be done, depends on what Thomas thinks!

@jmercouris
Copy link
Member

@lansingthomas what say ye?

@lansingthomas
Copy link
Contributor

Good idea.
Consistency is good for users.

Let's change the color of the buttons to reflect interaction state as as well.
Backward (not-clickable)
backward-history-1

  • surface: primary
  • text contrast-text

Backward (clickable)
backward-history

  • surface: action
  • text contrast-text

Forward (not clickable)
Forward-history-1

  • surface: primary
  • text contrast-text

Forward (clickable)
Forward-history

  • surface: action
  • text contrast-text

@lansingthomas
Copy link
Contributor

Dark theme:
backward: (not-clickable)
backward-history-1

backward (clickable)
backward-history

Forward (not-clickable)
Forward-history-1

Forward (clickable)
Forward-history

@lansingthomas
Copy link
Contributor

I want that nice blue to guide our new nyxters down the path :D

@jmercouris jmercouris self-assigned this Aug 7, 2023
@jmercouris
Copy link
Member

I shall prrrrrovide.

@lansingthomas
Copy link
Contributor

@jmercouris while you are in there, would you please make it so that left and right arrow keys change the pages appropriately in the quick-start

@aadcg
Copy link
Member Author

aadcg commented Aug 14, 2023

@jmercouris while you are in there, would you please make it so that left and right arrow keys change the pages appropriately in the quick-start

What's not working with respect to the arrows in the quick-start?

@jmercouris
Copy link
Member

I believe Thomas means the keyboard arrows.

@aadcg
Copy link
Member Author

aadcg commented Aug 14, 2023

@jmercouris, I see - binding keys in panel buffers. I think we lack the technical foundations to do that without a half-baked hack since we don't have the concept of focus in panel buffers.


@lansingthomas notice that in the proposed spec, the contrast between background and foreground is poor for all clickable elements. For instance, the contrast between #37a8e4 and #ffffff is less than 3. Given that these elements are extremely small, I would advice against it. The color that contrasts with #37a8e4 is black, not white.

@lansingthomas
Copy link
Contributor

lansingthomas commented Aug 14, 2023

Yeah good point Andre.

@jmercouris can you pretty please try these combos for the clickable-arrow-panel-buffer-buttons:

light theme default state: action (#37A8E4) for the surface color and text+ (#000000) for the arrow icons.
light theme hovered state: action+ (#72CDFE) for the surface color and text+ (#000000) for the arrow icons.

dark theme (amphora) default state: action (#4C21AB) for the surface color and text+ (#FFFFFF) for the arrow icons.
dark theme (amphora) hovered state: action+ (#571FD2) for the surface color and text+ (#FFFFFF) for the arrow icons.

@aadcg
Copy link
Member Author

aadcg commented Aug 14, 2023

@lansingthomas pro tip: if you surround hex colors in between ticks (`...`), the color is displayed.

Example: #37a8e4 (`#37a8e4`)

@jmercouris
Copy link
Member

Started on branch: quickstart-navigation-arrows but I can't yet get the computer to agree with me. A little more work yet.

@lansingthomas
Copy link
Contributor

@lansingthomas pro tip: if you surround hex colors in between ticks (...), the color is displayed.

aaaaaaaah coool #37a8e4
Thank you Andre :D

@jmercouris
Copy link
Member

Notice, the Pull request I made does not address the color changes. That is part of a bigger issue which I will tackle soon after!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Nyxt User Interface: themes, appearance and usability.
Development

Successfully merging a pull request may close this issue.

3 participants