Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit-with-external-editor is broken #3215

Closed
aadcg opened this issue Oct 13, 2023 · 1 comment · Fixed by #3232
Closed

edit-with-external-editor is broken #3215

aadcg opened this issue Oct 13, 2023 · 1 comment · Fixed by #3232
Assignees
@aadcg
Labels
bug

Comments

@aadcg
Copy link
Member

aadcg commented Oct 13, 2023 •
edited
Loading

As reported at https://discourse.atlas.engineer/t/basic-questions-setup-for-complete-beginner/886/12?u=aadcg.

Solution:

  1. text.lisp: Fix bug. snmsts/trivial-clipboard#19.
  2. Fully revert changes introduced in Support spaces in program string for EXTERNAL-EDITOR-PROGRAM. #2980. The consequences are more severe than what I've outlined before.
  3. 0cb39b9 as to ensure that the dev env can make use of clipboard facilities.
  4. Use reader macros to set external-editor-program to (list "gio" "open") by default on Flatpak or add the patch on Flathub.

Additionally, there's no point in having both edit-file-with-external-editor and edit-user-file-with-external-editor. One suffices.
@aadcg aadcg added the bug label Oct 13, 2023
@aadcg aadcg self-assigned this Oct 13, 2023
@apsinthium apsinthium mentioned this issue Oct 13, 2023
Closed
@aadcg
Copy link
Member Author

aadcg commented Oct 13, 2023 •
edited
Loading

I'll fix it as soon as the trivial-clipboard patch lands on Guix.

@aadcg aadcg mentioned this issue Oct 20, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aadcg aadcg

Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix external editor atlas-engineer/nyxt
1 participant
@aadcg