Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that hints are drawn within viewport #3250

Open
aadcg opened this issue Nov 8, 2023 · 4 comments
Open

Ensure that hints are drawn within viewport #3250

aadcg opened this issue Nov 8, 2023 · 4 comments
Labels
hint-mode ui/ux Nyxt User Interface: themes, appearance and usability.

Comments

@aadcg
Copy link
Member

aadcg commented Nov 8, 2023

While reviewing #3226, I noticed we don't provide this guarantee. In the example below, https://en.wikipedia.org/wiki/List_of_municipalities_in_Quebec has been zoomed as to have an element on the right edge.

2023_11_08_22:39:45-nyxt

@aadcg aadcg added ui/ux Nyxt User Interface: themes, appearance and usability. hint-mode labels Nov 8, 2023
@aartaka
Copy link
Contributor

aartaka commented Nov 30, 2023

This is not the problem with hint system, it's a bug in foreign interface. So here's how it happens:

  • Invoking zooming commands modifies buffer zoom settings.
  • This setting modification triggers (setf ffi-buffer-zoom-level) method.
  • This method tries to dispatch over the current buffer.
    • If it's a regular buffer, use fallback JavaScript-based zooming.
    • If it's a gtk-buffer, use WebKit-provided scrolling.
  • Here's when it breaks: buffer is inherited from gtk-buffer and thus is more specific.
  • So JavaScript-invoking method is picked instead of FFI one.
  • And thus the zooming is slightly broken, because JS-based zooming is somewhat broken by design.

@aartaka
Copy link
Contributor

aartaka commented Nov 30, 2023

Or we have two bugs 😃

@aadcg
Copy link
Member Author

aadcg commented Nov 30, 2023

The discussion about zooming is orthogonal to the issue at hand, as demonstrated in the screenshot below at URL https://maximilian-schillinger.de/tmp/hint-test.html.

2023_11_30_15:52:02-nyxt

@aartaka
Copy link
Contributor

aartaka commented Nov 30, 2023 via email

@aadcg aadcg mentioned this issue Jan 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint-mode ui/ux Nyxt User Interface: themes, appearance and usability.
Development

No branches or pull requests

2 participants