Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading Help buffer load DuckDuckGo #745

Closed
Daniel-V1 opened this issue May 20, 2020 · 4 comments
Closed

Reloading Help buffer load DuckDuckGo #745

Daniel-V1 opened this issue May 20, 2020 · 4 comments
Labels
good-first-issue Marks a good issue for first-time contributors. high lisp-protocol nyxt/lisp URLs and internal pages.

Comments

@Daniel-V1
Copy link

Describe the bug
When in the initial buffer or tutorial buffer, reloading the page instead loads DuckDuckGo.
I learned this when I was trying to see if loading a mode and then reloading the tutorial page would give me the new keybindings.

Precise recipe to reproduce the issue
Open next, run command reload-current-buffer

Information

  • Graphics card and driver: Nvidia, Nvidia
  • Desktop environment / Window manager name+version: i3 version 4.18.1 (2020-04-23) © 2009 Michael Stapelberg and contributors
  • How you installed Next (Guix pack, package manager, build from source): Source
  • Information from command copy-system-information:
    Next Version: 1.5.0-9ccda09c
    Lisp Implementation: SBCL
    Lisp Version: 2.0.3
    Operating System: Linux 5.6.13-arch1-1
    Features: (WEBKIT2 WEBKIT2-2.28 WEBKIT2-EMOJI WEBKIT2-MEDIA WEBKIT2-SANDBOXING
    GTK-3-22 GTK-3-20 GTK-3-18 GTK-3-16 GTK-3-14 GTK-3-12 GTK-3-10
    GTK-3-8 GTK-3-6 GTK-3-4 GTK GDK-3-22 GDK-3-20 GDK-3-18 GDK-3-16
    GDK-3-14 GDK-3-12 GDK-3-10 GDK-3-8 GDK-3-6 GDK-3-4 CAIRO-1-10
    CAIRO-1-12 GDK-PIXBUF GLIB-2-30 GLIB-2-32 GLIB-2-34 GLIB-2-36
    GLIB-2-38 GLIB-2-40 GLIB-2-42 GLIB-2-44 GLIB-2-46 GLIB-2-48
    GLIB-2-50 GLIB-2-52 GLIB-2-54 GLIB-2-56 GLIB-2-58 GLIB
    FSET-EXT-STRINGS SWANK PLUMP-UTF-32 GLOBAL-VARS DECLARE-TYPES
    PARENSCRIPT NAMED-READTABLES OSICAT-FD-STREAMS LPARALLEL 21BIT-CHARS
    CL-FAD CHUNGA FLEXI-STREAMS CLOSER-MOP CL-PPCRE-UNICODE CL-UNICODE
    CL-PPCRE BORDEAUX-THREADS LPARALLEL.WITH-CLTL2 LPARALLEL.WITH-CAS
    LPARALLEL.WITH-STEALING-SCHEDULER SPLIT-SEQUENCE GRAY-STREAMS
    FLAT-NAMESPACE X86-64 UNIX CFFI FLAT-NAMESPACE SEQUENCE-EMPTYP
    FAST-IO-SV FAST-IO SBCL-USES-SB-ROTATE-BYTE ASDF-SYSTEM-CONNECTIONS
    CL-JSON-CLOS CL-JSON THREAD-SUPPORT QUICKLISP
    SB-BSD-SOCKETS-ADDRINFO ASDF3.3 ASDF3.2 ASDF3.1 ASDF3 ASDF2 ASDF
    OS-UNIX NON-BASE-CHARS-EXIST-P ASDF-UNICODE X86-64 GENCGC 64-BIT
    ANSI-CL COMMON-LISP ELF IEEE-FLOATING-POINT LINUX LITTLE-ENDIAN
    PACKAGE-LOCAL-NICKNAMES SB-CORE-COMPRESSION SB-LDB SB-PACKAGE-LOCKS
    SB-THREAD SB-UNICODE SBCL UNIX)

Output when started from a shell
Next version 1.5.0-9ccda09c
[16:39:25] Using data profile "default".
[16:39:25] Listening to socket "/home/daniel/.local/share/next/next.socket".
[16:39:43] Loading global history of 11 URLs from "/home/daniel/.local/share/next/history.lisp".
[16:39:43] Saving session to "/home/daniel/.local/share/next/sessions/default.lisp".
[16:39:43] Loading "https://duckduckgo.com/?q=".
[16:39:43] Saving session to "/home/daniel/.local/share/next/sessions/default.lisp".
[16:39:45] Finished loading "https://duckduckgo.com/?q=".

@Ambrevar
Copy link
Member

Ambrevar commented May 21, 2020 via email

@Daniel-V1
Copy link
Author

Daniel-V1 commented May 21, 2020

It sounds to me like you've got the right ideas. For firefox it looks like extensions use a moz-extension: scheme, and for configuration they've got the about: scheme.
I don't know enough about the internals of Next and the underlying browser engines, but parse-url sounds like a reasonable place to do the scheme dispatch.
I searched a little bit for more information on docstring conventions, but didn't really find much for Common Lisp. I did find a reddit thread pointing me at the Emacs Lisp manual for docstring conventions though, and it looks like they just use quotes and keywords before them to disambiguate, so for class slots maybe just slot 'search-engines' or something.
Thank you so much for your work on this project!

https://www.gnu.org/software/emacs/manual/html_node/elisp/Documentation-Tips.html#Documentation-Tips

@Ambrevar
Copy link
Member

Thanks for the hints, I'll look more into this later, probably post 2.0.

@Ambrevar
Copy link
Member

This issue is gone since 2-pre-release-2. Regarding the cross-references, I've opened a new issue in #967.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Marks a good issue for first-time contributors. high lisp-protocol nyxt/lisp URLs and internal pages.
Development

No branches or pull requests

2 participants