Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: proxy-mode is misleadingly global #826

Closed
Ambrevar opened this issue Jul 4, 2020 · 2 comments
Closed

Security: proxy-mode is misleadingly global #826

Ambrevar opened this issue Jul 4, 2020 · 2 comments
Labels
2-series Related to releases whose major version is 2. security

Comments

@Ambrevar
Copy link
Member

Ambrevar commented Jul 4, 2020

Our proxy-mode is global, but as a mode it's meant to be buffer-local.
We are dangerously misleading our users here :(

The fix is to use per-buffer WebContexts.
The problem is that on doing so,

  1. It generates hundreds of
(process:23271): libsoup-WARNING **: 11:40:55.141: Failed to execute query: table soup_hsts_policies already exists

(process:23271): libsoup-WARNING **: 11:40:55.141: Failed to execute query: database is locked
  1. The browser tends to crash after about 1 minute, with
CORRUPTION WARNING in SBCL pid 23231(tid 0x7fd373667700):
Memory fault at (nil) (pc=0x7fd3796214e0, fp=0x7fd3640a4b48, sp=0x7fd3736661c0) tid 0x7fd373667700
The integrity of this image is possibly compromised.
Continuing with fingers crossed.

debugger invoked on a SB-SYS:MEMORY-FAULT-ERROR in thread
#<THREAD "cl-cffi-gtk main thread" RUNNING {1005E73CE3}>:
  Unhandled memory fault at #x0.

The current thread is not at the foreground,
SB-THREAD:RELEASE-FOREGROUND has to be called in #<SB-THREAD:THREAD "main thread" waiting on: #<MUTEX "thread result lock" owner: #<SB-THREAD:THREAD "cl-cffi-gtk main thread" RUNNING {1005E73CE3}>> {1000650083}>
for this thread to enter the debugger.

The 2 issues could be related. Let's get started with the first one.

@Ambrevar Ambrevar added the 2-series Related to releases whose major version is 2. label Jul 4, 2020
@Ambrevar
Copy link
Member Author

Ambrevar commented Jul 4, 2020

I've reported the libsoup issue upstream: https://gitlab.gnome.org/GNOME/libsoup/-/issues/192

@Ambrevar Ambrevar changed the title proxy-mode is misleadingly global Security: proxy-mode is misleadingly global Jul 4, 2020
@Ambrevar
Copy link
Member Author

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-series Related to releases whose major version is 2. security
Development

Successfully merging a pull request may close this issue.

1 participant