Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Isolate document specific serialize/deserialize from common stuff #3022

Closed
igarashitm opened this issue Jun 30, 2021 · 4 comments
Closed
Labels
cat/techdebt group/ui status/stale Issue considered to be stale so that it can be closed soon

Comments

@igarashitm
Copy link
Member

igarashitm commented Jun 30, 2021

ATM they are spreaded into mapping-serializer and related stuff, should be isolated from them and encapsulated into each document format specific model. The inspection context and UI-backend contract already have it

It would be even better to integrate with inspection models and centralize document format processor.

In principle mapping-serializer should not import these
https://github.com/atlasmap/atlasmap/pull/3021/files#diff-3d496db9295f525eb4259f99f3e4f663022a7f5bd328d4875045e86a11a954a7R80-R81
https://github.com/atlasmap/atlasmap/pull/3021/files#diff-3d496db9295f525eb4259f99f3e4f663022a7f5bd328d4875045e86a11a954a7R85
https://github.com/atlasmap/atlasmap/pull/3021/files#diff-3d496db9295f525eb4259f99f3e4f663022a7f5bd328d4875045e86a11a954a7R67

And all if (constants or properties) conditions, could be trickier though as they are special documents even at the presentation layer. But it should be possible to be cleaner.

@igarashitm igarashitm changed the title Isolate document specific serialize/deserialize from common stuff UI: Isolate document specific serialize/deserialize from common stuff Jun 30, 2021
@stale
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Oct 2, 2021
@igarashitm igarashitm removed the status/stale Issue considered to be stale so that it can be closed soon label Oct 4, 2021
@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Jan 3, 2022
@igarashitm igarashitm removed the status/stale Issue considered to be stale so that it can be closed soon label Jan 4, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Apr 16, 2022
@igarashitm igarashitm removed the status/stale Issue considered to be stale so that it can be closed soon label Apr 18, 2022
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Jul 31, 2022
@stale stale bot closed this as completed Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/techdebt group/ui status/stale Issue considered to be stale so that it can be closed soon
Projects
None yet
Development

No branches or pull requests

1 participant