Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Constant can be saved without any name/value or name even though they are required. #3303

Closed
mkralik3 opened this issue Sep 24, 2021 · 0 comments · Fixed by #3365 or #3394
Closed

[BUG] Constant can be saved without any name/value or name even though they are required. #3303

mkralik3 opened this issue Sep 24, 2021 · 0 comments · Fixed by #3365 or #3394
Assignees
@pleacu
Labels
cat/bug group/ui prio/p1

Comments

@mkralik3
Copy link

mkralik3 commented Sep 24, 2021 •
edited by igarashitm

xref: https://issues.redhat.com/browse/ENTESB-17377

Describe the bug
The modal dialog for creating constant in DataMapper shows that Name/Values fields are required but I am able (Create button is enabled) to create constant without any Name/Value (*)
image
or without Name.
image

  • only right after open the dialog, when I start typing name, the button is disabled.
    image

Original JIRA: https://issues.redhat.com/browse/ENTESB-17377
@pleacu pleacu self-assigned this Sep 24, 2021
pleacu pushed a commit to pleacu/atlasmap that referenced this issue Oct 8, 2021
fix: Correct validation of constant and property input
8643ab1 
Fixes: atlasmap#3303
@pleacu pleacu mentioned this issue Oct 8, 2021
Merged
igarashitm pushed a commit that referenced this issue Oct 10, 2021
@igarashitm
fix: Correct validation of constant and property input
d77ec8e 
Fixes: #3303
@igarashitm igarashitm reopened this Oct 13, 2021
pleacu pushed a commit to pleacu/atlasmap that referenced this issue Oct 13, 2021
fix: Correct validation of constant and property input (update)
36bbced 
Correct where a legal name is specified then backed over to an empty name
Fixes: atlasmap#3303
@pleacu pleacu mentioned this issue Oct 13, 2021
Merged
pleacu pushed a commit to pleacu/atlasmap that referenced this issue Oct 13, 2021
fix: Correct validation of constant and property input
8e15eed 
Corrected tooltip for empty name field
Fixes: atlasmap#3303
pleacu pushed a commit to pleacu/atlasmap that referenced this issue Oct 13, 2021
Tweeked story for constant dialog.
1828060 
Fixes: atlasmap#3303
pleacu pushed a commit that referenced this issue Oct 13, 2021
fix: Correct validation of constant and property input (update) (#3394)
407a6f4 
* fix: Correct validation of constant and property input (update)
Correct where a legal name is specified then backed over to an empty name
Fixes: #3303

* fix: Correct validation of constant and property input
Corrected tooltip for empty name field
Fixes: #3303

* Tweeked story for constant dialog.
Fixes: #3303

* one more tweek to stories
igarashitm pushed a commit that referenced this issue Oct 13, 2021
@igarashitm
fix: Correct validation of constant and property input (update) (#3394)
146b213 
* fix: Correct validation of constant and property input (update)
Correct where a legal name is specified then backed over to an empty name
Fixes: #3303

* fix: Correct validation of constant and property input
Corrected tooltip for empty name field
Fixes: #3303

* Tweeked story for constant dialog.
Fixes: #3303

* one more tweek to stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleacu pleacu

Labels
cat/bug group/ui prio/p1
Projects
None yet
Milestone
No milestone
3 participants
@igarashitm @pleacu @mkralik3