Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] AtlasMap is stuck after importing CSV on latest Google Chrome 105 #4320

Closed
mkralik3 opened this issue Sep 7, 2022 · 1 comment · Fixed by #4322
Closed

[BUG] AtlasMap is stuck after importing CSV on latest Google Chrome 105 #4320

mkralik3 opened this issue Sep 7, 2022 · 1 comment · Fixed by #4322
Assignees
@igarashitm
Labels
cat/bug group/ui

Comments

@mkralik3
Copy link

mkralik3 commented Sep 7, 2022 •
edited by igarashitm

Describe the bug
When I import CSV file into AtlasMap version 2.3.18, the UI is stuck on loading page. This happens only in Google Chrome. After that, refresh UI doesn't help and it is still stuck.
Also when I have already imported CSV via Firefox and then try open AtlasMap in Chrome, it is stuck until I delete CSV from in Firefox.

See video:
https://user-images.githubusercontent.com/16251792/188913385-efebc87a-81df-41cb-a59e-57d52e71cce3.mp4

Environment:
Fedora 36
This issue happens only in Google Chrome v 105.0.5195.52 . ( on version 102.0.5005.61 works )
No issue with Firefox 104.0

xref: https://issues.redhat.com/browse/ENTESB-19709
@igarashitm igarashitm self-assigned this Sep 7, 2022
@igarashitm
Copy link
Member

igarashitm commented Sep 8, 2022 •
edited

Root cause
https://developer.chrome.com/articles/fetch-streaming-requests/
sindresorhus/ky#450

And updating ky triggered a fire on outdated frontend toolchain. Since newer ky no longer provides umd module, Jest configuration needs to be updated to work with esm. Also react-scripts conflicts with newer ky.

/home/java11/workspace/atlasmap/ui/node_modules/ky/distribution/core/Ky.js 52:53
Module parse failed: Unexpected token (52:53)
File was processed with these loaders:
 * ../../node_modules/react-scripts/node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|         afterResponse: []
|       }, options.hooks),
>       method: normalizeRequestMethod(options.method ?? this._input.method),
|       // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
|       prefixUrl: String(options.prefixUrl || ''),

igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
663de76 
Fixes: atlasmap#4320
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
a60f4df 
Fixes: atlasmap#4320
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
ede7524 
Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
@igarashitm igarashitm mentioned this issue Sep 8, 2022
Merged
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
6089f03 
Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
3e42121 
Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
6a777e9 
Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
f525779 
Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
c5d8fb2 
Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Sep 8, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
d456a8c 
Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
@igarashitm igarashitm mentioned this issue Sep 8, 2022
Merged
igarashitm added a commit that referenced this issue Sep 9, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
158cdc1 
Fixes: #4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit that referenced this issue Sep 9, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
3273e26 
Fixes: #4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit that referenced this issue Sep 9, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
099dea4 
Fixes: #4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit that referenced this issue Sep 9, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
5e361a1 
Fixes: #4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
igarashitm added a commit to igarashitm/atlasmap that referenced this issue Oct 6, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105
fa5bf92 
Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
@igarashitm igarashitm mentioned this issue Oct 6, 2022
Merged
igarashitm added a commit to jboss-fuse/atlasmap that referenced this issue Oct 6, 2022
@igarashitm
fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105 (
7a86ad6 
#6)

Fixes: atlasmap#4320

Google Chrome 105 made a breaking change and made some case fail which used to be working fine with older Chrome.
https://developer.chrome.com/articles/fetch-streaming-requests/

ky made a fix for that
sindresorhus/ky#450

But since the newer ky no longer provides umd, we had to change the Jest configuration to deal with esm. Also we needed to introduce craco to add @babel/plugin-proposal-nullish-coalescing-operator which is required to update ky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

Labels
cat/bug group/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: AtlasMap is stuck after importing CSV on latest Google Chrome 105 igarashitm/atlasmap
2 participants
@igarashitm @mkralik3