Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENTESB-20837] Remove references to org.slfj4:slf4j-log4j12 #4584

Merged
merged 1 commit into from Mar 6, 2023
Merged

[ENTESB-20837] Remove references to org.slfj4:slf4j-log4j12 #4584

merged 1 commit into from Mar 6, 2023

Conversation

grgrzybek
Copy link

Fixes: #

@grgrzybek
Copy link
Author

@igarashitm please check this PR - not necessarily merge it. You can do it better probably, but we have to be sure that there's no org.slf4j:slf4j-log4j12 artifact referenced anywhere.

@igarashitm igarashitm enabled auto-merge (rebase) March 6, 2023 12:33
igarashitm
igarashitm approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@igarashitm igarashitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grgrzybek 👍

@grgrzybek
Copy link
Author

grgrzybek commented Mar 6, 2023 •
edited

ubuntu-latest/java11 and ubuntu-latest/java8 failed with:

Error:  NullPointerException
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error: Process completed with exit code 1.

no idea...

@grgrzybek
Copy link
Author

@igarashitm any hints about why ubuntu builds are failing?

@grgrzybek
Copy link
Author

anyway, I think it can be merged. What should I do?

@igarashitm
Copy link
Member

Hmm NPE when generating javadoc, strange... I'll take a look

@igarashitm igarashitm disabled auto-merge March 6, 2023 15:21
@igarashitm igarashitm merged commit 3d570e4 into atlasmap:atlasmap-2.3.x Mar 6, 2023
@igarashitm
Copy link
Member

hmm javadoc builds fine locally, anyway merging

@grgrzybek grgrzybek deleted the slf4j-log4j12-removal branch March 7, 2023 07:52
@grgrzybek
Copy link
Author

thanks @igarashitm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igarashitm igarashitm igarashitm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grgrzybek @igarashitm