Add an example to show how to create paginated result. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harikt
commented
Oct 13, 2016
| ->paging(20); | ||
| $result = $query->fetchRecordSet(); | ||
|
|
||
| $totalResult = clone $query; |
There was a problem hiding this comment.
I am not sure what should we call this object. totalQuery ?
|
I wonder if the thing to do here is to add a new method (e.g. |
pmjones
pushed a commit
that referenced
this pull request
Oct 13, 2016
|
Thanks Paul. Looks good to me.
Any reason you didn't called it |
|
One thing probably I think we could fix is the clone though. So if someone cloned it, it should not trouble them. |
|
Fixed by 3642fce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5 partially with documentation.
We can probably come with better ways later.
Thoughts ?