Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMock is deprecated #41

Closed
wants to merge 1 commit into from
Closed

getMock is deprecated #41

wants to merge 1 commit into from

Conversation

harikt
Copy link
Contributor

@harikt harikt commented Oct 20, 2016

PHPUnit 5.5+ deprecate message is thrown to use createMock or getMockBuilder instead of getMock .

See travis build https://travis-ci.org/atlasphp/Atlas.Orm/jobs/168678156

@pmjones
Copy link
Contributor

pmjones commented Oct 25, 2016

@harikt Looks like the Travis tests fail on this PR. Thoughts?

@harikt
Copy link
Contributor Author

harikt commented Oct 26, 2016

@pmjones I will send a patch to fix the same. Travis run phpunit 4.8 for hhvm and 5.6 . We can use getMockBuilder in this case.

@harikt
Copy link
Contributor Author

harikt commented Oct 26, 2016

Hi @pmjones ,

I have created 2 PR to address the same issue.

This one is modified to get latest version of phpunit downloaded on travis. There is a problem with that I fear. ( Long run we don't know what version of phpunit is giving us ) .

The second PR #42 uses getMockBuilder . I have created a TestCase class which extends PHPUnit_Framework_TestCase with a getMockFromBuilder method which internally uses the getMockBuilder functionality inside the createMock . You may wonder why not use createMock instead. The reason is createMock is not in version 4.8 from my understanding.

The phpunit information is gained working on auraphp/Aura.Intl#28 PR . In case you get some time please look into it also. So we can merge and release next version of Aura.Intl .

Thank you.

@pmjones
Copy link
Contributor

pmjones commented Feb 24, 2017

Closing, for now, in favor of 6ab7f82

@pmjones pmjones closed this Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants