Porting back changes from upstream PR to the fork #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tenaria
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Porting back all the changes from open-telemetry#7075 to the fork.
No functionality changes compared with the PR. Only changed to use the old OTEL(and Otel related)api/sdk.
More specifically, we are adding
to the current fork.
Link to tracking Issue:
Testing:
Tests are copied from the upstream PR and updated to use the old OTEL api/sdk.
The unit tests passed via
go test -count 1 -race ./...on Mac Catalina.(not on Monterey, the error is similar as the one reported here: golang/go#49138).Documentation:
As the upstream PR.