Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text spacing issue in Slack view oauth sessions #211

Closed
atl-lbernardo opened this issue Jul 20, 2022 · 4 comments
Closed

Text spacing issue in Slack view oauth sessions #211

atl-lbernardo opened this issue Jul 20, 2022 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@atl-lbernardo
Copy link

Why?

Found via https://jira.atlassian.com/browse/JSDSERVER-11885

Looks like a papercut fix in the properties file
https://github.com/atlassian-labs/atlassian-slack-integration-server/blob/master/slack-server-integration-common/src/main/resources/com/atlassian/plugins/slack/slack-common.properties#L134
@mvlasovatl mvlasovatl added bug Something isn't working good first issue Good for newcomers labels Jul 21, 2022
@atl-lbernardo atl-lbernardo changed the title Text spacing issue in Slack integration page Text spacing issue in Slack view oauth sessions Jul 23, 2022
@atl-lbernardo
Copy link
Author

hi @mvlasovatl i have a branch and fix ready id like to push to create a PR, do i have to be a contributor to do this? thanks

@mvlasovatl
Copy link
Collaborator

Hey @atl-lbernardo ! You may fork the repo, create a cross-repo PR. You don't need to be a collaborator for this.

mvlasovatl added a commit that referenced this issue Nov 25, 2022
@mvlasovatl
Merge pull request #239 from introvertkernel/master
5321288 
Issue  #211: Text spacing issue in Slack view oauth sessions
@mvlasovatl
Copy link
Collaborator

The fix is merged to dev now. It will be included into next release of each of the plugins.

@mvlasovatl
Copy link
Collaborator

The fix was included into the following releases:

  • Jira Server for Slack 3.0.4
  • Confluence Server for Slack 3.0.1
  • Bitbucket Server for Slack 4.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvlasovatl @atl-lbernardo