Bitbucket notifications for PR commits are missing

[madisparn]

Hello,

With Bitbucket Datacenter version 7.17.2 the slack notifications for new commits made under PR seem to be missing.
I get the emails with "person x pushed 1 change to PR name", but not in slack.

[mvlasovatl]

Hello @madisparn ! I tried to reproduce it on Bitbucket 7.17.2 and Bitbucket Server for Slack 4.0.6 and failed. I push commits to the source branch of a PR and still get notifications in Slack.
Are you sure that Commits -> Pushed notification event is enabled in your subscription?

[madisparn]

Hello, @mvlasovatl I do not see " Commits -> Pushed" notification setting on my subscription.

[mvlasovatl]

@madisparn It's missing on Personal notifications page you are referencing, but is present on the page of repository subscriptions. A screenshot of that page may be found on the plugin Marketplace page.

[madisparn]

@mvlasovatl I have not explicitly configured the settings for any repositories. And prefer not to. We have around 30 projects and 100 repositories.
I also want the notifications to go to the slack user directly, not to a channel.

[mvlasovatl]

That's a valid request. It isn't a bug though. Rather it's an ambiguous definition of what is "update" that's tracked by checkboxes on "Slack notifications" page in user profile section (Personal Notifications - PN). PR approval, "needs changes" review or a comment are considered an update that may trigger PN, but commits on PR - aren't. This logic is implemented in BitbucketNotificationEventListener and PersonalNotificationService. We may add commits to the list of PN-supported PR updates. Then the #277 needs to be updated accordingly.

[mvlasovatl]

Fix for this one has been fixed just released in version 4.0.9 🎉
Thank you for your efforts @madisparn!