-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaking CSS variables #333
Labels
bug 🐛
Something isn't working
Comments
🤔 What is this about? Edit: Is it variables we create for classes 🤔? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Blocked by facebook/react#20497 Edit: Unblocked! |
itsdouges
removed
the
blocked 🚫
This can't be completed because of something else
label
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Non-inherited CSS properties are being inherited thanks to the shared CSS variable declaration (they have the same name).
This is OK behaviour for properties that inherit - not ok for ones that shouldn't.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Nested
Box
should not have a border.Additional context
We can fix this by unsetting the CSS variable when it resolves to undefined.
Currently we resolve to an empty string if it has a prefix/suffix - to fix this we will probably have to always do it for everything.
Testing notes
The text was updated successfully, but these errors were encountered: