Refactor dynamic interpolations to use a util #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsdouges
force-pushed
the
interpolation-func
branch
from
a35fa09
to
19b2eb9
Compare
itsdouges
changed the title
itsdouges
force-pushed
the
interpolation-func
branch
2 times, most recently
from
f4aa4bc
to
266928b
Compare
itsdouges
force-pushed
the
interpolation-func
branch
from
c779711
to
284d31a
Compare
pgmanutd
reviewed
Dec 22, 2020
| * @param suffix | ||
| * @param prefix | ||
| */ | ||
| export default function cssCustomPropertyValue( |
There was a problem hiding this comment.
Do we need to do some perf testing here since we introduce this during runtime?
There was a problem hiding this comment.
Nevermind. It won't be that slow..hehe. Few if checks only.
|
Can we add bundlesize check for |
pgmanutd
reviewed
Dec 22, 2020
| * @param prefix | ||
| */ | ||
| export default function cssCustomPropertyValue( | ||
| value: string | number | number, |
There was a problem hiding this comment.
Suggested change
| value: string | number | number, | |
| value: string | number | undefined | null, |
itsdouges
force-pushed
the
interpolation-func
branch
from
9518198
to
b5b58c7
Compare
itsdouges
commented
Dec 22, 2020
| @@ -31,15 +31,15 @@ export type Interpolations<TProps extends Record<string, unknown>> = ( | |||
| * props from `StyledProps`. | |||
| */ | |||
| export interface StyledFunctionFromTag<TTag extends keyof JSX.IntrinsicElements> { | |||
| <TProps extends Record<string, unknown>>( | |||
| <TProps extends unknown>( | |||
There was a problem hiding this comment.
fixing types that i introduced a regression to in the TS change before, oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #346
Closes #333
This PR introduces an
ixfunction which handles CSS custom property values, with an optional suffix/prefix.Currently only the suffix and prefix handling is done for template literal CSS, so for example:
Would result in this
ixcall:If we did this for object CSS instead you would need to handle this yourself:
Which ends up with the
ixcall: