Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: short circuits css variable expressions to an empty string that have a prefix or suffix #204

Merged
merged 1 commit into from
May 27, 2020
Merged

fix: short circuits css variable expressions to an empty string that have a prefix or suffix #204

merged 1 commit into from
May 27, 2020

Conversation

itsdouges
Copy link
Collaborator

Closes #84

danieldelcore
danieldelcore approved these changes May 27, 2020
View reviewed changes
Copy link
Collaborator

@danieldelcore danieldelcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsdouges itsdouges merged commit ee6f862 into master May 27, 2020
@itsdouges itsdouges deleted the 84-fix-undefined-in-css branch May 27, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldelcore danieldelcore danieldelcore approved these changes

@flexdinesh flexdinesh flexdinesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using css variable that has a prefix/suffix should be conditionally applied
3 participants
@itsdouges @danieldelcore @flexdinesh