fix: simplify interpolation handling #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgmanutd
reviewed
Dec 19, 2020
| @@ -15,43 +11,25 @@ export interface BeforeInterpolation { | |||
| } | |||
|
|
|||
| /** | |||
| * Will return any suffix out of the CSS and return them both. | |||
| * Will remove any suffix out of the CSS and return them both. | |||
| * | |||
| * E.g. `'px;font-size: 20px;'` would return `"px"` as the suffix and `";font-size: 20px;"` as the CSS. | |||
There was a problem hiding this comment.
Should we add examples for more cases? Like when regex matched and when not. Might be helpful in future.
pgmanutd
reviewed
Dec 19, 2020
| @@ -62,39 +40,17 @@ export const cssAfterInterpolation = (css: string): AfterInterpolation => { | |||
| * @param css all the CSS before the interpolation | |||
There was a problem hiding this comment.
Can we add some examples here too? hehe
|
Looks good. Love that we have cleaned messy code hehe. If possible just add few examples in jsdoc which will be helpful for future developers. |
|
all done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the interpolation handling by making more assumptions, and handling only things that would actually happen. Obviously invalid suffix/prefixes and the like are now unsupported.
Closes #413
Closes #345