JPERF-273 Switch to hooks preserving backwards compatibility #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrzaslewicz
force-pushed
the
issue/JPERF-273-consume-infra-hooks-fix-dc
branch
from
f16b440
to
7768137
Compare
pczuj
reviewed
Sep 8, 2023
| private val provisionedNetwork: ProvisionedNetwork by lazy { networking.get() } | ||
| private val network: Network by lazy { provisionedNetwork.network } | ||
| private val provisioning: ProvisionedStack by lazy { provisionStack() } | ||
| private val deprovisioning: CompletableFuture<*> by lazy { |
There was a problem hiding this comment.
Probably not important, but accessing this will first provision and then deprovision, so if we call close without serveTcp we would waste some time and resources - possibly without knowing.
There was a problem hiding this comment.
good point, deprovisioning replaced by resources
mgrzaslewicz
force-pushed
the
issue/JPERF-273-consume-infra-hooks-fix-dc
branch
5 times, most recently
from
005ead4
to
602488b
Compare
Consume infra 34fdce5 Next steps: * pristine Jira DC Plan unencumbered by `LegacyAwsInfrastructure` or CFN * bridge from `JiraInstancePlan` to `JiraFormula` if possible * bridge the other way around if possible * can `SambaSharedHome` really work with just `TcpNode`? * do we actually need `Reports` transport via S3? * do we need bulk/directory transport for `Reports`? * add jpt-workspace as CI artifact * make hook collections append-only (`PreInstanceHooks` already are)
Use the same dataset and Jira version in tests as infrastructure lib. Attempt to fix problems with mysql configuration
mgrzaslewicz
force-pushed
the
issue/JPERF-273-consume-infra-hooks-fix-dc
branch
from
602488b
to
7eb1fc7
Compare
Replace the `LegacyAwsInfrastructure.balance` bridge method with `Ec2Balancer`, which combines the responsibilities of old-API `ApacheEc2LoadBalancerFormula` and the bridge method. It allocates AWS resources in EC2 directly, rather than reusing the CloudFormation stack. That's why we need a common `resources` queue.
Consume infra 000ce569f0332f958fe94241dc90ffa24183d1ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume infra 3aacf87
Next steps:
LegacyAwsInfrastructureor CFNJiraInstancePlantoJiraFormulaif possibleSambaSharedHomereally work with justTcpNode?Reportstransport via S3?Reports?PreInstanceHooksalready are)