Merge pull request #58 from ecosia/mp-arguments-array

Change arguments to list to accommodate for arguments without values.
atlassian · Apr 30, 2019 · 20cbdb1 · 20cbdb1
2 parents 31382b2 + f3e8b20
commit 20cbdb1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/multirun/README.md b/multirun/README.md
@@ -26,9 +26,11 @@ load("@com_github_atlassian_bazel_tools//:multirun/def.bzl", "multirun", "comman
 command(
     name = "command1",
     command = "//some/label",
-    arguments = {
-        "-arg1": "value1",
-    },
+    arguments = [
+        "-arg1",
+        "value1",
+        "-arg2",
+    ],
     environment = {
         "ABC": "DEF",
     },

diff --git a/multirun/def.bzl b/multirun/def.bzl
@@ -103,8 +103,8 @@ def _command_impl(ctx):
         for k, v in ctx.attr.raw_environment.items()
     ]
     str_args = [
-        "%s=%s" % (k, shell.quote(v))
-        for k, v in ctx.attr.arguments.items()
+        "%s" % shell.quote(v)
+        for v in ctx.attr.arguments
     ]
     command_elements = ["exec env"] + \
                        str_env + \
@@ -130,8 +130,8 @@ def _command_impl(ctx):
 _command = rule(
     implementation = _command_impl,
     attrs = {
-        "arguments": attr.string_dict(
-            doc = "Dictionary of command line arguments",
+        "arguments": attr.string_list(
+            doc = "List of command line arguments",
         ),
         "environment": attr.string_dict(
             doc = "Dictionary of environment variables",