This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Multirun rule #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash2k
force-pushed
the
multirun
branch
3 times, most recently
from
03a5842
to
25f2bc7
Compare
nilebox
approved these changes
Jul 5, 2018
amckague
reviewed
Jul 10, 2018
| @@ -0,0 +1,37 @@ | |||
| # multirun | |||
|
|
|||
| Bazel rule to `bazel run` multiple executable targets sequentially. | |||
There was a problem hiding this comment.
Is the fact that the command runs inside bash part of your contract?
There was a problem hiding this comment.
It is not specified, so no. Is this important?
There was a problem hiding this comment.
not sure, at first glance I see the wrap user controlled string in bash and wonder if I can put arbitrary bash commands into that string. It looks like we're assuming the input is a file name which is different.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works, but I'm just using it for self education to learn more about runfiles and hence it is cluttered with
printstatements. So this is for early feedback, not for merging just yet.