Work around publish Dokka problem
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was discovered using the gradle-release devloop: atlassian-labs/gradle-release@806c334 Here, in Docker infra, it was locally confirmed by `publishToMavenLocal --stacktrace`. Before: ``` * What went wrong: org/jetbrains/kotlin/gradle/dsl/KotlinSingleTargetExtension > org.jetbrains.kotlin.gradle.dsl.KotlinSingleTargetExtension * Try: > Run with --info or --debug option to get more log output. * Exception is: java.lang.NoClassDefFoundError: org/jetbrains/kotlin/gradle/dsl/KotlinSingleTargetExtension at org.jetbrains.dokka.gradle.kotlin.KotlinCompilationUtilsKt.allCompilationsOf(kotlinCompilationUtils.kt:25) at org.jetbrains.dokka.gradle.kotlin.IsMainSourceSetKt.isMainSourceSet(isMainSourceSet.kt:10) at org.jetbrains.dokka.gradle.kotlin.KotlinSourceSetGistKt$gistOf$2.call(KotlinSourceSetGist.kt:21) at org.jetbrains.dokka.gradle.kotlin.KotlinSourceSetGistKt$gistOf$2.call(KotlinSourceSetGist.kt) at org.gradle.api.internal.provider.DefaultProvider.calculateOwnValue(DefaultProvider.java:72) BUILD FAILED in 11s ``` After: ``` BUILD SUCCESSFUL in 4s 10 actionable tasks: 4 executed, 6 up-to-date ```
pczuj
reviewed
Jun 12, 2024
| @@ -4,9 +4,10 @@ val testContainersVersion = "1.17.5" | |||
| val log4jVersion = "2.17.2" | |||
|
|
|||
| plugins { | |||
| // gradle-release has to go first, see https://github.com/atlassian-labs/gradle-release/pull/5/commits/0e89b0646d3393e5cf2827240d64bc9bdc2060c1 | |||
There was a problem hiding this comment.
Nit: Maybe it's just me, but I find the message of linked commit not completely clear. I don't think that matters too much though.
There was a problem hiding this comment.
True, the second paragraph is the most relevant part, the first one is only partially talking about what will happen if we don't have the workaround. I should have split that commit into two.
pczuj
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered using the gradle-release devloop: atlassian-labs/gradle-release@806c334
Here, in Docker infra, it was locally confirmed by
publishToMavenLocal --stacktrace.Before:
After: