Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ forwardRef wrapped in a memo now works with type inference #163

Merged
merged 1 commit into from
Mar 1, 2021
Merged

✨ forwardRef wrapped in a memo now works with type inference #163

merged 1 commit into from
Mar 1, 2021

Conversation

danieldelcore
Copy link
Contributor

Closes #162

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2021

⚠️ No Changeset found

Latest commit: f6d6219

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pgmanutd
pgmanutd reviewed Feb 26, 2021
View reviewed changes
packages/extract-react-types/converters-typescript.test.js
foo: string,
}

const MyComponent = memo(forwardRef<HTMLElement, MyComponentProps>((props, ref) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will forwardRef also works without generics? Like this:

const MyComponent = memo(forwardRef((props: MyComponentProps, ref: React.Ref<HTMLElement>) => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Yeah that should work, there's a test case for this above I'm pretty sure 😀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be in the flow tests actually

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. @Madou: You have any comments? Looks good to me overall.

itsdouges
itsdouges approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@itsdouges itsdouges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danieldelcore danieldelcore merged commit af117aa into master Mar 1, 2021
@danieldelcore danieldelcore deleted the 162-memo-inference branch March 1, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgmanutd pgmanutd pgmanutd left review comments

@itsdouges itsdouges itsdouges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add support for forwardRef used within memo using TS type inference
3 participants
@danieldelcore @itsdouges @pgmanutd