prTitle and prRef are now hashed - removed payload dump on log #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshkay10
commented
Sep 19, 2022
| @@ -4,7 +4,7 @@ import bformat from "bunyan-format"; | |||
| import { DEBUG } from "bunyan"; | |||
| import { createHashWithSharedSecret } from "utils/encryption"; | |||
|
|
|||
| const SENSITIVE_DATA_FIELDS = ["jiraHost", "orgName", "repoName", "userGroup", "userGroup", "aaid", "username"]; | |||
| const SENSITIVE_DATA_FIELDS = ["jiraHost", "orgName", "repoName", "userGroup", "userGroup", "aaid", "username", "prTitle", "prRef"]; | |||
There was a problem hiding this comment.
As we find more UGC/PII we continue to add to this list.
Its manageable at the moment but may need to consider moving it to a config file of some sort if it gets too massive!!
bgvozdev
approved these changes
Sep 19, 2022
This was referenced Jun 23, 2023
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adding prTitle and prRef to the sensitive data list
Removing a complete payload object in a log
Why
prTitle and prRef is UGC and needs to be hidden
an entire payload it too much logging! we need to be targeted, payload is ok during debug but not as a default, we cannot always be sure what is in it and could potentially leak PII/UGC
Added feature flags
nope
Affected issues
nope
How has this been tested?
locally only, changes are minor enough that I feel this is sufficient.
Whats Next?
Keep hunting for UGC!