Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship It - Adding comments from GitHub to Jira #1637

Merged
merged 16 commits into from Oct 7, 2022
Merged

Ship It - Adding comments from GitHub to Jira #1637

merged 16 commits into from Oct 7, 2022

Conversation

krazziekay
Copy link
Collaborator

What's in this PR?

  • Webhook for deleting issue comments added.
  • Endpoint added for editing and deleting issue comments.
  • Added Handler for addressing changes in issue comments - not completely finished

Why

  • Ship it

- New comment adding done
@krazziekay krazziekay self-assigned this Sep 29, 2022
@atrigueiro
Copy link
Contributor

atrigueiro commented Oct 6, 2022

Additional comments for getting this PR merged - and for future reference:

What's in this PR?

  • Webhook for deleting issue comments added.
  • Endpoint added for editing and deleting issue comments.
  • Added handler for addressing changes in issue comments - not completely finished
  • Tests updated

Why

  • Ship it :) + it's a feature customers have been asking for

Screen Shot 2022-10-06 at 4 43 23 pm

Screen Shot 2022-10-06 at 4 43 11 pm

Added feature flags

  • Yes. send-pr-comments-to-jira_zy5ib

Affected issues

How has this been tested?

  • Locally

What's Next?

  • Add missing typings
  • Add tests for updating and deleting a comment
  • Check how we want to treat the getCommentId function - right now we're only getting the first 50
  • Do we want to consider issue keys added on PR titles as well - right now we're only getting from the branch
  • Return the function if no issue keys are found - and add tests for that.
  • Markdown - do we want to add a transform to send the markdown in the accepted format by Jira?
  • Ask Jade's opinion on how should we display the comment

@atrigueiro
Copy link
Contributor

Related to #1618

@atrigueiro atrigueiro marked this pull request as ready for review October 6, 2022 06:55
@atrigueiro atrigueiro requested a review from a team as a code owner October 6, 2022 06:55
atrigueiro
atrigueiro previously approved these changes Oct 7, 2022
@amcfarland-linus
Copy link

amcfarland-linus commented Nov 16, 2023

@krazziekay @atrigueiro Is listing all PR comments in JIRA, once it has been merged, possible using this feature? I don't see it listed anywhere under JIRA smart values. I am trying to create an automation rule that would look like:

  1. When: Pull request merged
  2. Then: Add comment to issue
# Comment body in Jira
{{pullRequest.title}}
{{pullRequest.state}}
{{pullRequest.sourceBranch}}

{{pullRequest.comments}}   <- trying to output ALL comments in the PR that was merged to be sent into the created Jira comment via the automation rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants