Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARC-1728 - Success Page after creating a branch #1660

Merged
merged 3 commits into from Oct 12, 2022
Merged

ARC-1728 - Success Page after creating a branch #1660

merged 3 commits into from Oct 12, 2022

Conversation

krazziekay
Copy link
Collaborator

What's in this PR?

  • Added the final success state in the same page using jQuery. This is not done in a separate route as intended previously, because:
    • Creating a new route means redirect, which means we lose the animating flow.
    • There鈥檚 not much value in creating a separate route for this.
  • After the branch has been created successfully, added a 1.5 second timeout to show the action links.

Why

  • Following the UI with the smooth animation 馃槑

How has this been tested?

  • Local
  • Staging

Video

Screen.Recording.2022-10-12.at.4.35.09.pm.mov

@krazziekay krazziekay self-assigned this Oct 12, 2022
@krazziekay krazziekay requested a review from a team as a code owner October 12, 2022 05:37
joshkay10
joshkay10 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@joshkay10 joshkay10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer it staying on the page so that a win to me!!

@krazziekay krazziekay merged commit 0f91c25 into main Oct 12, 2022
@krazziekay krazziekay deleted the ARC-1728 branch October 12, 2022 22:56
@Manny27nyc Manny27nyc mentioned this pull request Jun 23, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 23, 2023
Open
@nickfnblum nickfnblum mentioned this pull request Jun 23, 2023
Open
@Manny27nyc Manny27nyc mentioned this pull request Jun 24, 2023
Open
@rachellerathbone rachellerathbone mentioned this pull request Jun 24, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshkay10 joshkay10 joshkay10 approved these changes

Assignees

@krazziekay krazziekay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krazziekay @joshkay10