ARC-1736 create branch ff view #1662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachellerathbone
force-pushed
the
ARC-1736-ff-create-branch-route
branch
from
d2373bc
to
902b577
Compare
rachellerathbone
changed the title
joshkay10
reviewed
Oct 12, 2022
krazziekay
previously approved these changes
Oct 12, 2022
krazziekay
reviewed
Oct 12, 2022
…n/github-for-jira into ARC-1736-ff-create-branch-route
rachellerathbone
force-pushed
the
ARC-1736-ff-create-branch-route
branch
from
bfad1d8
to
c9c3401
Compare
krazziekay
previously approved these changes
Oct 12, 2022
src/routes/github/create-branch/github-create-branch-options-get.test.ts
Outdated
Show resolved
Hide resolved
joshkay10
requested changes
Oct 13, 2022
rachellerathbone
force-pushed
the
ARC-1736-ff-create-branch-route
branch
from
e96dc71
to
78808d9
Compare
|
We ended up going with a diff option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
A temporary view that we'll render if the CB ff is off for customers.
Why
Coz it's what the CB team decided to do. Figured it won't be up for long and this option has a much faster turn-around time then trying to battle with the Jira codebase 😱 Plus, we now have this coming soon component if we ever need it again.
Added feature flags
Pretty self-explanatory.
Affected issues
ARC-1736
How has this been tested?
Locally: ff off, ff on :)
Screen.Recording.2022-10-12.at.5.25.23.pm.mov
Whats Next?
Wrapping up 1740 - the initial view you see when the ff is on. Mostly done. Just need to do a couple of small things and some clean up.