ARC-1520: kill of manage subscriptions page #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te github subscription page and get middleware
rachellerathbone
changed the title
joshkay10
pushed a commit
that referenced
this pull request
Feb 28, 2023
add delete subscription functionality to connect an org page and delete github subscription page and get middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The death of the manage subscriptions page :rip:
The connect an org page has been updated so you'll now see a trash can instead of the settings icon:
If you hover over it when the org hasn't been connected, you'll see the button is disabled and has the following tooltip:
And if you're not an admin you'll see:
Demo of delete sub from connect an org page:
Cloud:
Screen.Recording.2023-02-09.at.4.48.37.pm.mov
Server:
Screen.Recording.2023-02-09.at.4.51.56.pm.mov
Why
We were seeing some issues around deleting subscriptions from this page: in some scenarios I could delete a jira host's subscription even if I had navigated from a different hosts. And other times a legitimate subscription delete didn't work :sigh:
We talked about potentially disabling the button for any host other than the one the user navigated from:
but determined we should've list all connected hosts, opting to add the same functionality to the Connect an org page.
Affected issues
ARC-1520
How has this been tested?
In staging.
Whats Next?
Uh signing off... it's basically 5pm bro