JPERF-249 Chromedriver continues to work after a page load timeout.

Use patched chromedriver that workarounds the problem. Chromedriver installer contains information about the patch.
atlassian · Jan 17, 2019 · e5a45ef · e5a45ef
1 parent 0a8a0be
commit e5a45ef
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,7 +29,8 @@ Dropping a requirement of a major version of a dependency is a new contract.
 ### Fixed
 - Bump MySQL to 5.6.42. Resolve [JPERF-345].
 - Set up VUs only once per node in `MulticastVirtualUsers`. Fix [JPERF-346].
-
+- Chromedriver continues to work after a page load timeout. Fix [JPERF-349].
+
 ### Added
 - Separate Chromium implementations, like `Chromium69` or `Chromium70`. Resolve [JPERF-350].
 - Install Chromium with a compatible chromedriver. Resolve [JPERF-352].
@@ -44,6 +45,7 @@ Dropping a requirement of a major version of a dependency is a new contract.
 [JPERF-346]:https://ecosystem.atlassian.net/browse/JPERF-346
 [JPERF-350]:https://ecosystem.atlassian.net/browse/JPERF-350
 [JPERF-352]:https://ecosystem.atlassian.net/browse/JPERF-352
+[JPERF-349]:https://ecosystem.atlassian.net/browse/JPERF-349
 
 ## [4.5.1] - 2019-01-04
 [4.5.1]: https://bitbucket.org/atlassian/infrastructure/branches/compare/release-4.5.1%0Drelease-4.5.0

diff --git a/.../kotlin/com/atlassian/performance/tools/infrastructure/api/browser/chromium/Chromium69.kt b/.../kotlin/com/atlassian/performance/tools/infrastructure/api/browser/chromium/Chromium69.kt
@@ -8,7 +8,7 @@ import java.net.URI
 
 class Chromium69 : Browser {
     private val chromiumUri = URI("https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/Linux_x64%2F576753%2Fchrome-linux.zip?generation=1532051976706023&alt=media")
-    private val chromedriverUri = URI("https://chromedriver.storage.googleapis.com/2.43/chromedriver_linux64.zip")
+    private val chromedriverUri = URI("https://s3.eu-central-1.amazonaws.com/jpt-chromedriver/2.43/chromedriver.zip")
 
     /**
      * Installs chromium 69 with a compatible chromedriver.

diff --git a/.../kotlin/com/atlassian/performance/tools/infrastructure/api/browser/chromium/Chromium70.kt b/.../kotlin/com/atlassian/performance/tools/infrastructure/api/browser/chromium/Chromium70.kt
@@ -8,7 +8,7 @@ import java.net.URI
 
 class Chromium70 : Browser {
     private val chromiumUri = URI("https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/Linux_x64%2F587811%2Fchrome-linux.zip?generation=1535668921668411&alt=media")
-    private val chromedriverUri = URI("https://chromedriver.storage.googleapis.com/2.43/chromedriver_linux64.zip")
+    private val chromedriverUri = URI("https://s3.eu-central-1.amazonaws.com/jpt-chromedriver/2.43/chromedriver.zip")
 
     /**
      * Installs chromium 70 with a compatible chromedriver.