fix(public): fix dependencies failing to build on Ubuntu 18.04 LTS #61
Conversation
Both SASS and SQlite3 failed to build on Ubuntu 18.04 LTS. This upgrades both to the current version, fixing this problem
| @@ -54,7 +54,7 @@ | |||
| "semver": "^5.4.1", | |||
| "sequelize": "^4.11.1", | |||
| "sequelize-typescript": "^0.5.0", | |||
| "sqlite3": "^3.1.12", | |||
| "sqlite3": "^4.0.3", | |||
There was a problem hiding this comment.
This concerns me (probably more than it should because sqlite is only used in development) but I don't to break anyone using it in prod 🤔
Why can't sqlite3 be build on ubuntu 18.04? Normally those issues can be resolved just by installing the required deps
There was a problem hiding this comment.
Looking at the changelog: my problems were probably caused by either the old node-pre-gyp version bundled with 3.1.13 or the lack of Node 10 support before 4.0.1. The bump from v3 to v4 seem to be nothing but the removal of support for old Node versions.
Given that Node.js 10 will be the latest LTS starting on tuesday I think supporting it is a good goal.
probably more than it should because sqlite is only used in development
Given that sqlite is the example config and isn't cautioned against anywhere I would be willing to bet that the majority of Nucleus instances outside Atlassian do use sqlite in production.
MarshallOfSound
force-pushed
the
master
branch
3 times, most recently
from
7010a90
to
78f5ecc
Compare
Both SASS and SQlite3 failed to build on Ubuntu 18.04 LTS. This upgrades both dependencies to the current
version, fixing this problem.
Note that the sqlite update is an update by a whole major version. I haven't noticed any issues, but maybe you want to double-check.