#38: ignore decoration nodes in findDomRefAtPos #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5id
reviewed
Jun 26, 2018
src/selection.js
Outdated
| const child = dom.node.childNodes[i]; | ||
| // ignore decoration DOM nodes as ProseMirror ignores it while calculating the offset | ||
| if ( | ||
| child.nodeType === 1 && |
5id
reviewed
Jun 26, 2018
| @@ -164,6 +164,17 @@ export const findPositionOfNodeBefore = selection => { | |||
| // ``` | |||
| export const findDomRefAtPos = (position, domAtPos) => { | |||
| const dom = domAtPos(position); | |||
| const node = dom.node.childNodes[dom.offset]; | |||
| let { offset } = dom; | |||
| for (let i = 0, count = dom.node.childNodes.length; i < count; i++) { | |||
There was a problem hiding this comment.
If I have something like:
let { offset, node } = dom;
offset = 1;
node.childNodes = [decoration, decoration, myThing, decoration, decoration];
won't this set the offset to 5?
There was a problem hiding this comment.
I'll add a test for it
eshvedai
force-pushed
the
issue-38-findDomRefAtPos
branch
2 times, most recently
from
caad1ea
to
dc82a0d
Compare
ahixon
reviewed
Jun 26, 2018
__tests__/selection.js
Outdated
| deco2.className = 'fake-decoration2 ProseMirror-widget'; | ||
| view.dom.insertBefore(deco2, view.dom.childNodes[1]); | ||
|
|
||
| // prepend a fake decoration node 1 |
eshvedai
force-pushed
the
issue-38-findDomRefAtPos
branch
from
dc82a0d
to
97d6c80
Compare
ahixon
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #38