New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Flow to TypeScript #982

Open
alexreardon opened this Issue Dec 4, 2018 · 9 comments

Comments

Projects
None yet
5 participants
@alexreardon
Copy link
Contributor

alexreardon commented Dec 4, 2018

At Atlassian we consolidating on a single type system: TypeScript.

In 2019 we plan on moving react-beautiful-dnd to TypeScript.

We still hope to have a good flow story through the flowtyped project. We can essentially just use our existing flow types for a react-beautiful-dnd library definition.

@alexreardon

This comment has been minimized.

Copy link
Contributor Author

alexreardon commented Dec 4, 2018

For me personally this is not a negative reflection on flow. I really enjoy using it. However, there are advantages for us in consolidating on a type system internally. Also, my understanding is that TypeScript is a more popular project so a lot more people will get first class types when we move over

❤️

@alexreardon alexreardon changed the title Move from Flow to TypeScript Move from Flow to TypeScript (early 2019) Dec 4, 2018

@alexreardon alexreardon changed the title Move from Flow to TypeScript (early 2019) Move from Flow to TypeScript Dec 4, 2018

@TrySound

This comment has been minimized.

Copy link
Contributor

TrySound commented Dec 5, 2018

I would prefer you to keep flow types up-to-date in this repo. As you can see there's not so much people who will maintain them separately.

@TrySound

This comment has been minimized.

Copy link
Contributor

TrySound commented Dec 27, 2018

How about rewriting with reason? Type system is much nicer.

@lilymatcha

This comment has been minimized.

Copy link

lilymatcha commented Jan 2, 2019

@alexreardon This is an exciting development! Since Typescript is more widely used, it will also help make it easier for people to contribute to the project. Within 2019, what is your expected timeline for this migration?

@treshugart

This comment has been minimized.

Copy link

treshugart commented Jan 7, 2019

Just as we didn't want to maintain TS types when the source was in Flow, I don't think it's worth maintaining Flow types when moving to TS.

@lilymatcha Alex will be back mid-Jan. See #1010 for more details.

@TrySound

This comment has been minimized.

Copy link
Contributor

TrySound commented Jan 7, 2019

@treshugart Flow types will be maintained. There are existing users.

@alexreardon

This comment has been minimized.

Copy link
Contributor Author

alexreardon commented Jan 23, 2019

@TrySound I am still thinking of the best way to maintain the flow types. Given they already exist I am open to having them in the repo. Once we start on the TypeScript conversion then we will have a better idea what the story could be

@TrySound

This comment has been minimized.

Copy link
Contributor

TrySound commented Jan 23, 2019

Types will be quite small. So it won't take a lot of efforts to maintain them. Keeping them separately will make them out of date soon.

@mdestagnol

This comment has been minimized.

Copy link

mdestagnol commented Jan 25, 2019

@alexreardon good news for typescript. Do you guys also plan to move over Atlaskit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment