Move from Flow to TypeScript

[100terres]

Description

Related to: atlassian/react-beautiful-dnd#982

• Minimal TypeScript support with declaration file (Add TypeScript declaration files #3)
• Upgrade Storybook to v6 (Built-in TypeScript support) (Upgrade Storybook to v6 #9)
• Upgrade @rollup/* (Upgrade @rollup/* #13)
• Move Storybook and stories to TypeScript (Move Storybook and stories to TypeScript #14)
• Move our tests to TypeScript (Move our tests to TypeScript #15)
• Move our source files to TypeScript (Move our source files to TypeScript #10)
• Clean up any unused Flow related code or definitions #131
• Update documentation related to Flow and TypeScript #134
• (Nice to have) Help wanted Support Flow type definition #132

[ghost]

Hey @100terres, great to see you effort on this fork! 😻 How can we support you to get this done?

[100terres]

Hi @finnatinform, I’m currently working on migrating the test suit to TypeScript (#15) and I’ll follow with the migration of the source code (#10). I should be able to have a major part of the work done in a couple of days. I think what would be appreciated is to have other people review the code. I’ll do my best to make the review process as easy as it can be, but since it will affect almost all files it might be cumbersome task to do 😅. I’ll also need help to keep Flow support (type declaration), since I’m not a Flow developer/user. After that we’ll have a clean slate to really build on top of and start tackling issues opened on react-beautiful-dnd. If you have any suggestions feel free to comment and/or open issues! 🙂

[JamesGelok]

We could use flowgen to help make flow types from our typescript types

https://github.com/joarwilk/flowgen

(I'm not a flow developer either 😅)

[100terres]

@JamesGelok thank you for the suggestion! 🙂 🎉

[cmacdonnacha]

Hey @100terres , just wondering if there's anything we can help with here?

[100terres]

Hi @cmacdonnacha thanks for pinging me! I was a bit busy at work in the last couple weeks, but I recently managed to migrate all the files in the src folder to TypeScript. I'll open a couple of PRs during the weekend and I'll add you as a reviewer 🙂

After that I've already started the migrations of the test folder to TypeScript, but there is still work to do to properly finished migration to TypeScript. If you want, once the migration of the src folder is merged, I could leave it to you to finished the migration of the test folder? 🙂

[100terres]

Hi there! Just to give you all feedback! Sorry, to have left this work unfinished! I'll push to finish this and really take the time to maintain this repo 🙂

Sorry again and I won't let you down this time 🙂

[100terres]

Here's an update of where we currently are:

• MMigrate src/ from Flow to TypeScript ✔️
• Fix all TypeScript errors from the src/ ✔️
• MMigrate test/ from Flow to TypeScript ✔️
• Fix all TypeScript errors from the test/ ⛔ We still have more than 549 errors to fix, but the migration is going smootly 🙂

I'll try to give you an other update in the upcoming days!

[100terres]

We are now at 487 errors 🙂 📉

[100terres]

We are now at 395 TypeScript/typings errors. Just to mention the tests themselves are passing 🙂

[100terres]

We are now at 138 TypeScript errors! Almost done! 🙂

[100terres]

Will be done soon! Only 59 errors left 🙂

[100terres]

No more TypeScript errors ✔️

Next step I'll do some clean-up 🧹

[100terres]

I'll be able to do release v14.0.0-alpha.5 soon 🙂

[100terres]

The only thing missing here is the support of flow declaration:

• Support Flow type definition #132

But for now it will be a nice to have. If anyone would like to tackle this issue and open a PR I'll gladly review it and merge it 🙂

This conclude the migration from flow to TypeScript!

[100terres]

v14.0.0 released 🙂