Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ie 11 window scroll fix #1091

Merged
merged 4 commits into from
Feb 3, 2019
Merged

Ie 11 window scroll fix #1091

merged 4 commits into from
Feb 3, 2019

Conversation

alexreardon
Copy link
Collaborator

@alexreardon alexreardon commented Feb 3, 2019

Fixes #1088

Unlike all other browsers, ie11 will propagate all container scroll events up to the window

Tested in:

  • firefox
  • chrome
  • safari
  • ie11
  • edge

@alexreardon
Copy link
Collaborator Author

ie11 - what a pain

@alexreardon alexreardon merged commit 4518e53 into master Feb 3, 2019
@alexreardon alexreardon deleted the ie-11-window-scroll-fix branch February 3, 2019 23:22
// IE11 fix:
// Scrollable events still bubble up and are caught by this handler in ie11.
// We can ignore this event
if (event.currentTarget !== getWindow()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexreardon This actually doesn't fix the issue for IE11.

// IE11 fix:
// Scrollable events still bubble up and are caught by this handler in ie11.
// We can ignore this event
if (event.currentTarget !== getWindow()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexreardon This actually doesn't fix the issue for IE11.

@muchamateusz
Copy link

I just encountered this issue on ie11. It is not fixed.

@wstransky
Copy link

I still have this issue on IE11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto scrolling a fixed positioned container doesn't work in IE11
4 participants