Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emotion again #1128

Merged
merged 7 commits into from
Feb 28, 2019
Merged

Emotion again #1128

merged 7 commits into from
Feb 28, 2019

Conversation

alexreardon
Copy link
Collaborator

No description provided.

@varHarrie
Copy link

Why Emotion? Just be curious.

@alexreardon
Copy link
Collaborator Author

Why Emotion? Just be curious.

There is almost nothing between them. We are thinking of consolidating internally on emotion and I wanted to give it a go for a while.

Longer answer:

  • performance: similar
  • kbs: emotion is a bit smaller (not super important for our doc site)
  • emotion has a more flexible api which can help us achieve behaviours that are harder with styled-components
  • emotion has a cleaner SSR story
  • emotion has a styled.div syntax so you can use it exactly the same and you would styled-components. This also allows for a simpler rollback path.

Given it was so easy to change, we might change back in the future too

@alexreardon alexreardon merged commit 48107d1 into dev Feb 28, 2019
@alexreardon alexreardon deleted the emotion-again branch February 28, 2019 21:17
@varHarrie
Copy link

Thank for your clear explanation. I am a heavy user for styled-components and a defector of emotion. I had forgotten the reason since they are too similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants