Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly importing react types to avoid deprecation warnings #184

Merged
merged 1 commit into from Nov 20, 2017
Merged

explicitly importing react types to avoid deprecation warnings #184

merged 1 commit into from Nov 20, 2017

Conversation

alexreardon
Copy link
Collaborator

This was caused by using the recommended flow pattern:

import * as React from 'react';

However, doing this causes deprecation warnings to fire.

facebook/flow#4673

Now explicitly importing required types from react rather than using the import * method.

@alexreardon alexreardon merged commit 97c05dd into master Nov 20, 2017
@alexreardon alexreardon deleted the removing-console-warnings branch November 20, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredcrowe jaredcrowe jaredcrowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexreardon @jaredcrowe