Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyboard to move item between vertically stacked lists #555

Closed
wants to merge 2 commits into from

Conversation

sbutkaliuk
Copy link

@sbutkaliuk sbutkaliuk commented Jun 19, 2018

This adds possibility to move item to the next list (vertically) with same UP/DOWN buttons that used to move through the list itself. Fixes: #219

Solution is based on existing movement between different lists but adds opposite axis parameter.

Testing: add flex-direction: column to multi-drag/task-app.jsx#Container

sbutkaliuk added 2 commits June 19, 2018 15:43
This adds possibility to move item to the next list (vertically)
with same UP/DOWN buttons that used to move through the list itself.

Solution is based on existing movement between different lists
but adds opposite axis parameter.

Testing: add `flex-direction: column` to multi-drag/task-app.jsx#Container
@nehaabrol87
Copy link

@alexreardon This is something we need for our app.
I want to check did we follow protocol for opening this PR?
If not, who do we have to alert.

@alexreardon
Copy link
Collaborator

Very cool!!! 🎉 I am keen to see this happen. I am hesitant to make this change until #77 (and there is another placeholder issue too).

That will give us a better base before adding this. It should happen not to long from now as #219 is a priority for us. Once #484 and #511 are done we will start working on the placeholders which will unblock this. We should also build a good example that exercises this well with droppable and page scrolling included.

Sorry to hold things up, but i don't want to lock us into a corner just yet!

@alexreardon
Copy link
Collaborator

I am really keen for this - i think we should just wait a little bit longer for some ground work. We might just be able to reopen this and go from there!

@nehaabrol87
Copy link

Thanks @alexreardon for now we will fork the repo.
Any idea around what timeframe would this be incorporated so that we can include a TODO in our code based and we can stop using the forked version of this repo.

@nehaabrol87
Copy link

nehaabrol87 commented Jul 16, 2018

@alexreardon qq I see for accessibility support it only says single list?
Is that true?
https://react-beautiful-dnd.netlify.com/?selectedKind=Accessibility&selectedStory=single%20list&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

We are trying to implement it for multiple vertical lists and were not sure if this library is a good fit though.
Any tips/tricks that would be helpful?

@alexreardon
Copy link
Collaborator

It works perfectly for multiple lists.

Here is our screen reader guide: https://github.com/atlassian/react-beautiful-dnd/blob/master/docs/guides/screen-reader.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants