Checking that the window is defined before accessing it. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following the fix laid out here for universal apps. |
|
Looking good. I'll have a quick scan through, but i do not think we are using any other browser globals on launch. |
alexreardon
requested changes
Aug 31, 2017
src/state/create-store.js
Outdated
| import { applyMiddleware, createStore, compose } from 'redux'; | ||
| import thunk from 'redux-thunk'; | ||
| import reducer from './reducer'; | ||
| import hookMiddleware from './hook-middleware'; | ||
| import type { Store, Hooks } from '../types'; | ||
|
|
||
| // eslint-disable-next-line no-underscore-dangle | ||
| const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose; | ||
| const composeEnhancers = typeof window === 'object' |
There was a problem hiding this comment.
Can you please add a comment above stating
- We are checking if window is available because it might not be when server side rendering
- That this came from https://github.com/zalmoxisus/redux-devtools-extension#12-advanced-store-setup
|
Thanks for looking into this @romellogood !!!! |
|
I have forked your example. I found it was not doing the correct SSR (it was returning |
|
Once you add the comments listed above we are good to go |
|
Made the changes you requested! |
alexreardon
approved these changes
Aug 31, 2017
|
🎉 I will try to do a release tomorrow afternoon which will contain this fix. Well done @romellogood ! |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should take care of issue #65
Checking that the window is defined before accessing it so that the module doesn't break on the server.