Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings): Add write_to_file #38

Merged
merged 1 commit into from
Sep 24, 2019
Merged

feat(settings): Add write_to_file #38

merged 1 commit into from
Sep 24, 2019

Conversation

YuukanOO
Copy link
Member

@YuukanOO YuukanOO commented Sep 23, 2019 •
edited

Closes #29

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@YuukanOO YuukanOO added the enhancement New feature or request label Sep 23, 2019
@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #38 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #38      +/-   ##
===========================================
+ Coverage    98.57%   98.59%   +0.01%     
===========================================
  Files           22       22              
  Lines         1053     1067      +14     
===========================================
+ Hits          1038     1052      +14     
  Misses          15       15
Impacted Files Coverage Δ
pytlas/settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c24f3...560fbfe. Read the comment docs.

@YuukanOO YuukanOO merged commit c48c3e8 into develop Sep 24, 2019
@YuukanOO YuukanOO deleted the feature/settings-write-to-file branch September 24, 2019 07:26
YuukanOO added a commit that referenced this pull request Sep 26, 2019
@YuukanOO
v5.1.0 (#39)
f0d61a3 
* fix: Add os.makedirs for the interpreter cache directory (#35)
* feat(settings): Add to_dict to convert a store to a dictionary representation (#36)
* feat(settings): getpath now resolve path from the loaded config path if any (#37)
* feat(settings): Add write_to_file (#38)
* chore: Bump version to 5.1.0
YuukanOO added a commit that referenced this pull request Sep 27, 2019
@YuukanOO
feat(settings): Add write_to_file (#38)
6ee4084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@YuukanOO