Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready For Review] Auto-Solver #2

Merged
merged 25 commits into from
Sep 17, 2023
Merged

[Ready For Review] Auto-Solver #2

merged 25 commits into from
Sep 17, 2023

Conversation

Andrew1431
Copy link
Collaborator

@Andrew1431 Andrew1431 commented Sep 12, 2023 •
edited

Thought you might want to keep up with my auto-solver code!

  • Inferred react props
  • CSS Variables (in canvas if possible?)
  • remove inline styles
  • camelCase dir-names
  • validate all key configurations in game

Fixes #1

atlesque
atlesque requested changes Sep 12, 2023
View reviewed changes
Copy link
Owner

@atlesque atlesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on both the canvas code and refactoring! 💪

src/components/modules/auto-solver/Key.tsx Outdated Show resolved Hide resolved
src/components/modules/settings/Settings.tsx Outdated Show resolved Hide resolved
src/hooks/useCanvasDraw.ts Outdated Show resolved Hide resolved
src/pages/AutoSolverPage.tsx Outdated Show resolved Hide resolved
src/pages/SolverPage.tsx Outdated Show resolved Hide resolved
src/components/modules/auto-solver/Key.tsx Outdated Show resolved Hide resolved
@Andrew1431 Andrew1431 changed the title [WORK IN PROGRESS] Auto-Solver Auto-Solver Sep 14, 2023
@Andrew1431 Andrew1431 mentioned this pull request Sep 14, 2023
Closed
@Andrew1431 Andrew1431 changed the title Auto-Solver [PROBLEM FOUND, FIXING] Auto-Solver Sep 14, 2023
@Andrew1431 Andrew1431 changed the title [PROBLEM FOUND, FIXING] Auto-Solver [Ready For Review] Auto-Solver Sep 15, 2023
atlesque
atlesque requested changes Sep 16, 2023
View reviewed changes
Copy link
Owner

@atlesque atlesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few more comments to check. I'll update linter rules later to make it easier. For future PRs, let's try to keep them a little smaller to it's easier to review. And great job on the auto-solver! 💯

src/components/modules/autoSolver/Key.module.scss Outdated Show resolved Hide resolved
src/components/modules/autoSolver/Key.module.scss Outdated Show resolved Hide resolved
src/components/modules/autoSolver/Key.module.scss Outdated Show resolved Hide resolved
src/components/modules/autoSolver/Key.module.scss Outdated Show resolved Hide resolved
src/components/modules/autoSolver/Key.module.scss Outdated Show resolved Hide resolved
src/styles/palette.ts Outdated Show resolved Hide resolved
src/utils/solvePuzzle.ts Outdated Show resolved Hide resolved
src/utils/solvePuzzle.ts Outdated Show resolved Hide resolved
src/utils/solvePuzzle.ts Outdated Show resolved Hide resolved
src/utils/solvePuzzle.ts Outdated Show resolved Hide resolved
@Andrew1431
Copy link
Collaborator Author

For future PRs, let's try to keep them a little smaller to it's easier to review. And great job on the auto-solver! 💯

yeah this got way out of hand fast :P

Andrew1431
Andrew1431 commented Sep 16, 2023
View reviewed changes
Copy link
Collaborator Author

@Andrew1431 Andrew1431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing now!

src/components/modules/autoSolver/Key.module.scss Outdated Show resolved Hide resolved
src/utils/solvePuzzle.ts Outdated Show resolved Hide resolved
src/utils/solvePuzzle.ts Outdated Show resolved Hide resolved
@Andrew1431
Copy link
Collaborator Author

@atlesque all finished!

@Andrew1431
Copy link
Collaborator Author

Weird, some of your comments got hidden, fixed the component-hook and <hr 100% />

@atlesque atlesque closed this Sep 17, 2023
@atlesque atlesque reopened this Sep 17, 2023
@atlesque atlesque merged commit 5de464b into atlesque:main Sep 17, 2023
@atlesque
Copy link
Owner

🎉🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlesque atlesque atlesque approved these changes

Assignees

@Andrew1431 Andrew1431

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Auto Solver
2 participants
@Andrew1431 @atlesque