Allow customizing the fontFace URL for production environment through cssFontsUrl. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakigakki
changed the title
atlowChemi
reviewed
Jun 20, 2023
Comment on lines
+89
to
+90
| this.emitFile({ type: 'asset', fileName: `assets/${processedOptions.fontName}-${guid()}.${type}`, source: generatedFonts?.[type] }), | ||
| ).replace('assets', cssFontsUrl)}`, |
There was a problem hiding this comment.
would this work also?
Suggested change
| this.emitFile({ type: 'asset', fileName: `assets/${processedOptions.fontName}-${guid()}.${type}`, source: generatedFonts?.[type] }), | |
| ).replace('assets', cssFontsUrl)}`, | |
| this.emitFile({ type: 'asset', fileName: `${cssFontsUrl}/${processedOptions.fontName}-${guid()}.${type}`, source: generatedFonts?.[type] }), | |
| )`, |
There was a problem hiding this comment.
I tried, but unfortunately, it appears to be unsuccessful.
There was a problem hiding this comment.
Doesn't this mean we emit the file to 1 location (assets), and then import it from another location (cssFontsUrl)?
There was a problem hiding this comment.
Yes, indeed. It may be because I specified rollupOptions.build.out, so the emitted files will be placed in the assets folder under the out directory.
There was a problem hiding this comment.
Would this work when not setting that setting as you have?
Would you be willing to fix this if not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow customizing the Css fontFace URL for production environment through options.cssFontsUrl.