COUNTER_Robots_list.json: Escape literal dots #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some patterns are incorrect because they mean to use a literal dot, but we should technically be escaping these to use literal dots in regex. Note that we need to escape the first backslash in the JSON so we can get a literal backslash for escaping the dots in the out- put file. The dot in the "virus.detector" pattern seems to be inte- ntional, as this user agent sometimes appears as virus-detector and other times as virus_detector. Also I've taken the liberty to add URLs and descriptions where app- licable.
alanorth
force-pushed
the
regex-dot-escaping
branch
from
8ec8959
to
f5de7e6
Compare
|
Rebased against latest master branch. |
alanorth
added a commit
to ilri/DSpace
that referenced
this pull request
Jul 20, 2020
These are waiting to be merged into the COUNTER-Robots project: - New bots: https://github.com/atmire/COUNTER-Robots/pulls - Escape literal dots: atmire/COUNTER-Robots#35 - Remove okhttp anchors: atmire/COUNTER-Robots#33
alanorth
added a commit
to ilri/DSpace
that referenced
this pull request
Jul 20, 2020
These are waiting to be merged into the COUNTER-Robots project: - New bots: https://github.com/atmire/COUNTER-Robots/pulls - Escape literal dots: atmire/COUNTER-Robots#35 - Remove okhttp anchors: atmire/COUNTER-Robots#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some patterns are incorrect because they mean to use a literal dot, but we should technically be escaping these to use literal dots in regex. The dot in the
virus.detectorpattern seems to be intentional, as this user agent sometimes appears asvirus-detectorand other times asvirus_detectorfrom what I can see in other block lists (I have not seem this bot myself). Note that we need to escape the first backslash in the JSON so we can get a literal backslash for escaping the dots in the output file.Also I've taken the liberty to add URLs and descriptions where applicable.