Beginning to deepcopy workspace #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikssonpatrick This is what you asked for: deep copies of the workspace. I only tested it on some very simple stuff though, as I as of now have no use for this so no test case set up. |
olemke
requested changes
Sep 12, 2022
There was a problem hiding this comment.
At least a minimal test cases should be included. Nothing fancy, but at least something that verifies the intended behaviour. Something like:
- Create a workspace
- Set one variable to a known value
- Make a deep-copy
- Change the variable value in the original workspace
- Verify that the variable in the copied workspace still has the correct, original value
|
Just a clarification. I asked about this, but that was under the assumption that the feature existed. I got that impression from some discussion. |
|
@olemke This now has the tests you requested. |
olemke
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.