-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARTS3] Mocking scattering data interface. #719
base: main
Are you sure you want to change the base?
Conversation
@riclarsson As per out discussion from last week, I started replacing ParticulatePropertyTag with ScatteringSpeciesProperty as defined in src/core/scattering/properties.h. Could you have a look a that as well as the changes in atm.h? Thanks! |
Nice! Two things. The first serious, the second a minor design choice (that also has a bug). The big problem first: The second minor thing: |
src/core/scattering/properties.h
Outdated
bool operator==(const ScatteringSpeciesProperty& other) const { | ||
return (species_name == other.species_name) && | ||
(pproperty == other.pproperty); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constexpr auto operator<=>(const ScatteringSpeciesProperty& other) const = default;
@simonpf This does not compile so merging main arts3-dev is not good. There seems to be some problems with duplicate |
7c67ccf
to
ddaaf70
Compare
So, this should in principle build. Could you add fftw3 to the build environment @olemke ? |
Python interface is already created via `arts_options.cc`.
This PR aims to sketch out the ARTS integration of the new scattering data handling.