Auto ID for document() #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
commented
Feb 26, 2020
| expect(snapshot1.documentID, nonExistentId); | ||
| // TODO: data field should be null before the document is saved | ||
| // https://github.com/atn832/cloud_firestore_mocks/issues/21 | ||
| // expect(snapshot1.data, isNull); |
There was a problem hiding this comment.
This assertion fails under current implementation. It’s unexpectedly an empty map.
| QuerySnapshot querySnapshot = | ||
| await firestore.collection('users').getDocuments(); | ||
| // TODO: assert result length size. It should be 1. | ||
| // https://github.com/atn832/cloud_firestore_mocks/issues/20 |
There was a problem hiding this comment.
Under current implementation, the query snapshot unexpectedly holds 2 documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14 .
Due to complexity in updating tests, I left the behavior of
document.addunchanged. For example, https://github.com/atn832/cloud_firestore_mocks/pull/22/files#diff-e8ee19ddcfe4302627bdf8313dad3f9bR280 Expecting document ID “zz”