support metadata changes #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting in all that work @danReynolds. Before I review the PR, would you mind writing unit tests to test all the new changes you've made? This helps with the review because it shows how it's used, and also ensures that no one accidentally breaks your code in the future. |
|
Yep! Added some @atn832 thanks. Let me know if there's anything else you need. |
atn832
reviewed
Dec 11, 2022
| @@ -26,7 +26,10 @@ class FakeConvertedQuery<T extends Object?> extends FakeQueryWithParent<T> { | |||
| toFirestore: _converter.toFirestore) | |||
| .get()) | |||
| .toList(); | |||
| return MockQuerySnapshot(await Future.wait(convertedSnapshots)); | |||
| return MockQuerySnapshot( | |||
There was a problem hiding this comment.
Very nice of you to remember the case of converted queries as well.
|
The tests really helped me navigate your PR. Thanks! |
|
Just published your feature to https://pub.dev/packages/fake_cloud_firestore/changelog#210. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for specifying metadata changes coming from the cache or not like the cloud_firestore API supports.