Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle geopoint in encoder #257

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Handle geopoint in encoder #257

merged 2 commits into from
Dec 28, 2022

Conversation

gaburielcasado
Copy link
Contributor

@gaburielcasado gaburielcasado commented Dec 27, 2022 •
edited
Loading

Convert GeoPoint to a map so that dump does not crash if the fake firestore instance contains a GeoPoint object.

#35

@gaburielcasado gaburielcasado mentioned this pull request Dec 27, 2022
Closed
@atn832
Copy link
Owner

atn832 commented Dec 27, 2022

Thanks for the PR. This looks alright. Would you mind adding a GeoPoint to the unit test for dump?

fake_cloud_firestore/test/fake_cloud_firestore_test.dart

Line 29 in 3f9c6f7

'name': 'Bob',

@gaburielcasado
Copy link
Contributor Author

@atn832 test added

@atn832 atn832 merged commit ac1d536 into atn832:master Dec 28, 2022
@atn832
Copy link
Owner

atn832 commented Dec 28, 2022

Thanks @ga-bri-el !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaburielcasado @atn832