Fix docChanges removed, modified and added with proper index values
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KholmatovS
changed the title
docChanges removed, modified and added with proper index values
KholmatovS
force-pushed
the
fix/documents_type_change
branch
from
86efc4b
to
0e07234
Compare
KholmatovS
force-pushed
the
fix/documents_type_change
branch
from
0e07234
to
975e441
Compare
atn832
reviewed
Dec 26, 2023
Comment on lines
+1720
to
+1723
| // after adding doc 2 (ordered by name) | ||
| ['Gwen', 'Norman'], | ||
| // after updating doc 2 (Gwen -> Peter, order by name ) | ||
| ['Norman', 'Peter'], |
There was a problem hiding this comment.
Very nice and thorough test case, and great documentation
…e_change # Conflicts: # lib/src/query_snapshot_stream_manager.dart
|
@atn832 resolved merge conflicts |
atn832
reviewed
Dec 26, 2023
atn832
reviewed
Dec 26, 2023
atn832
reviewed
Dec 26, 2023
|
Just published your pull requests to https://pub.dev/packages/fake_cloud_firestore/changelog#245. Thanks for the great update! |
|
hey, after upgrading to this version my snapshot listener is not receiving events when calling 
|
|
Nevermind, I think the issue is somewhere else. I think now we're not checking the type when creating new instances but here we are, so if we use a converter in the app but a simple reference in the tests, I think this will drop the update |
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #224 .
Also fixed proper snapshot query emitting when document modified/removed preserving old and new indexes.